imaginary icon indicating copy to clipboard operation
imaginary copied to clipboard

add file: Dockerfile-jemalloc

Open wuzhihui1123 opened this issue 3 years ago • 6 comments

Add the Dockerfile-jemalloc file to build the imaginary of jemalloc. solve the memory leak problem

wuzhihui1123 avatar Aug 02 '21 07:08 wuzhihui1123

Can you please provide some additional information about the underlying issue and how does jemalloc solves the problem?

h2non avatar Aug 07 '21 16:08 h2non

Can you please provide some additional information about the underlying issue

#342 , #314 , #198

Some have identified MALLOC_ARENA_MAX as helpful, which has been reflected in the project README. Others noticed switching to jemalloc can further resolve the issue, where it's been clarified in issues on the libvips project repo IIRC, and one user in the imaginary linked issues references imgproxy docs that details both of these memory tweaks/fixes together.

This PR should probably document somewhere such as the README about why jemalloc variant may be relevant to try. Could be as simple as copy/paste or link referencing imgproxy docs on the subject.

Probably would be good if someone verifies with a before & after result of the Dockerfile resolving the issue too.

polarathene avatar Aug 21 '21 08:08 polarathene

@polarathene I'm curious if I should pull this into our current fork, can you provide some benchmarks, as well as docker stats if possible?

angelo-hub avatar Oct 18 '21 20:10 angelo-hub

@polarathene Also there was a small update to the docker file to upgrade to golang 1.17, can you merge them in here too?

angelo-hub avatar Oct 18 '21 20:10 angelo-hub

@angelo-hub I'm not the author of this PR, I do not use imaginary.

My comment was added when I was looking at the project among others, I saw this PR and thought I'd pass some information along at the time. I have no time available for contributions sorry :(

polarathene avatar Oct 19 '21 07:10 polarathene

@angelo-hub do you maintain a more recent fork/build of imaginary?

zenyui avatar Jun 28 '23 20:06 zenyui