Tom comments

Results 281 comments of

Tom

fix some missing log informations and add VerifyJSON assert method

Thanks for the PR. Please, take a look to my comments.

fix some missing log informations and add VerifyJSON assert method

Thanks! Will take a look soon.

Question: Is true streaming supported?

Nope, not planned to be supported soon, but PRs are welcome.

Implement Image.Composite and blend modes

Will try to take a look this weekend.

bimg drains out the system memory in case of Pixel flood attack

Thanks for the report. I understand the pixel flood attack vector is the same as the one described here (there is also an image for reproducibility): https://hackerone.com/reports/842462 Ideally, I believe...

bimg drains out the system memory in case of Pixel flood attack

Thanks for the insights @jcupitt! I plan to implement safe image validation at `bimg` level, just for convenience, but in the meantime, you can simply validate the image size before...

feat: Implement AddText function, test and example

Watermark text is already supported in the API. What's the additional benefit of having this feature?

Support RGBA in background color

Happy to help merge a PR implementing this!

Stop printing VIPS_WARNING messages to console

Happy to merge a PR improving this. I would expect at least two ways of setting the warning verbose behavior: - Via environment variable `BIMG_DEBUG=`, or fallback to `VIPS_WARNING`. -...

Question: Is there any way to put an angle on a text based watermark?

You can try using an already rotated transparent PNG image as a watermark. See: - https://godoc.org/github.com/h2non/bimg#Image.WatermarkImage - https://godoc.org/github.com/h2non/bimg#WatermarkImage