bimg icon indicating copy to clipboard operation
bimg copied to clipboard

TestEXIF failing

Open Tachi107 opened this issue 4 months ago • 1 comments

Hi!

When trying to build the project, I encountered a test failure of TestEXIF test.

Build environment:

  • bimg 1.1.9
  • go 1.24
  • libvips 8.16.1
  • Debian Testing (forky)

Here's the error:

=== RUN   TestEXIF
    metadata_test.go:268: Unexpected image exif ExifVersion: Exif Version 2.31 != Unknown Exif Version
--- FAIL: TestEXIF (0.01s)

Related to #479

Tachi107 avatar Aug 22 '25 16:08 Tachi107

Here's a diff fixing the issue. Of course, this will break the test for old libvips versions.

diff --git a/metadata_test.go b/metadata_test.go
index 68502f2..e8b5849 100644
--- a/metadata_test.go
+++ b/metadata_test.go
@@ -177,7 +177,7 @@ func TestEXIF(t *testing.T) {
 			FNumber:                 "9/5",
 			ExposureProgram:         2,
 			ISOSpeedRatings:         25,
-			ExifVersion:             "Unknown Exif Version",
+			ExifVersion:             "Exif Version 2.31",
 			DateTimeOriginal:        "2020:07:28 19:18:49",
 			DateTimeDigitized:       "2020:07:28 19:18:49",
 			ComponentsConfiguration: "Y Cb Cr -",

Tachi107 avatar Aug 22 '25 16:08 Tachi107