bimg icon indicating copy to clipboard operation
bimg copied to clipboard

add position and allow 0 margin for text watermark

Open fajrifernanda opened this issue 4 years ago • 9 comments

Add position(left and top) to set the position of text watermark

and allow 0 margin on text watermark

this is sample of 0 margin, left(0), top(imageheight-fontheight) resize (1)

fajrifernanda avatar Jul 13 '20 02:07 fajrifernanda

Hey, that's great! Just dropping in to say two things:

  1. It will probably be good to add tests to resizer_test.go and vips_test.go
  2. I am really looking forward for @h2non to accept this, because we're going to rely on Imaginary and this exact functionality in our project; and this PR allows these issues to be closed:

Eptarch avatar Sep 14 '20 09:09 Eptarch

@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr

fajrifernanda avatar Sep 14 '20 10:09 fajrifernanda

Any plans on merging this?

Leterax avatar Oct 07 '21 15:10 Leterax

please merge~

huntrist avatar Mar 07 '22 12:03 huntrist

bump

Drabuna avatar Jun 15 '22 14:06 Drabuna

@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr

Hi @fajrifernanda, did you add some tests to your project later?

suntong avatar Dec 01 '23 16:12 suntong

Oh~~~

This branch has conflicts that must be resolved now, after more than three years.

suntong avatar Dec 01 '23 17:12 suntong

Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?

suntong avatar Dec 02 '23 03:12 suntong

Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?

NVM, I got it -- https://github.com/suntong/bimg/commit/44218a7e47610f5c4ac41ea9f41912bb36a352f7

suntong avatar Dec 02 '23 19:12 suntong