bimg
bimg copied to clipboard
add position and allow 0 margin for text watermark
Add position(left and top) to set the position of text watermark
and allow 0 margin on text watermark
this is sample of 0 margin, left(0), top(imageheight-fontheight)
Hey, that's great! Just dropping in to say two things:
- It will probably be good to add tests to resizer_test.go and vips_test.go
- I am really looking forward for @h2non to accept this, because we're going to rely on Imaginary and this exact functionality in our project; and this PR allows these issues to be closed:
@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr
Any plans on merging this?
please merge~
bump
- It will probably be good to add tests to resizer_test.go and vips_test.go
@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr
Hi @fajrifernanda, did you add some tests to your project later?
Oh~~~
This branch has conflicts that must be resolved now, after more than three years.
Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?
Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?
NVM, I got it -- https://github.com/suntong/bimg/commit/44218a7e47610f5c4ac41ea9f41912bb36a352f7