baloo icon indicating copy to clipboard operation
baloo copied to clipboard

Published 20 hours ago • verified publisher icon h2non

Bubble Up regexp Error For BodyMatchString

Open midnightconman opened this issue 6 years ago • 2 comments

This should make fixing regex pattern issues easier... to bubble up an error like this:

https://play.golang.org/p/dubZiQ-HCN0

midnightconman avatar Jan 09 '19 23:01 midnightconman

Tests are failing. Can you take a look?

h2non avatar Jan 10 '19 10:01 h2non

Sorry this took so long, I missed this PR :smiley_cat:

I am not sure this test failure is related to my changes, what do you think?

--- FAIL: TestJSONSchemaInvalid (0.00s)
	<autogenerated>:1: 
		json_schema_test.go:67: should be == 
		 	have: (bool) false
			want: (bool) true

I don't see any error handling in the code base around the function I changed... can you take a look and let me know if you can find any additional info?

midnightconman avatar Jan 05 '20 21:01 midnightconman