Greg Ziółkowski

Results 179 comments of Greg Ziółkowski

Is there any reason why this PR is marked as a draft? All tests still pass 😄 @t-hamano, thank you for working on it. @ciampo, there are still 60-ish test...

I now see that @walbo also opened PR https://github.com/WordPress/gutenberg/pull/43069 that refactors test files to use RTL instead of enzyme. I think it's a good opportunity you team up together and...

@ciampo, processing 60 files isn't a simple effort. I feel you 😄 Anyway, if someone wants to champion the coordination process that would be ace!

> I know we are not there yet because we cannot easily hide/show individual controls of a block today but as far as I'm aware the block bindings API is...

> It seems only the schema of block.json and documentation is in the Gutenberg repository. The code to load those assets is in core: [here](https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/blocks.php#L468) and [here](https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-block.php#L271). So should I...

I have just committed core changes with https://github.com/WordPress/wordpress-develop/commit/1a5ff3fc6dbe45376b54335028d8e9b19da93244. Let's finish the Gutenberg changes now. Awesome work @gaambo 💯

The documentation changes are in place in Gutenberg with https://github.com/WordPress/gutenberg/pull/55492. It would be nice to replicate something similar to what @sirreal did in https://github.com/WordPress/gutenberg/pull/57437 for `viewModule`, and bring the same...

> Regarding core 6.3/6.4 back-compat: I'm sorry, I don't think I'll be able to do this in the following weeks, so if anybody wants to take over, feel free. Otherwise,...

> @gziolo I've added a PR for pre 6.5 compat for viewStyles here: #59322 Excellent, thank you!

Yes, I have just approved #59322 with the backport from WP core. The dev note covering this new feature was published, too. Once the PR lands, this issue will get...