Greg Ziółkowski

Results 179 comments of Greg Ziółkowski

If possible it would be great to maintain all ESLint rules from a central location using overrides: https://github.com/WordPress/gutenberg/blob/59f42b3aed9c40165515629613d8e5920bb74977/.eslintrc.js#L179 Otherwise it’s harder to reason how rules resolve because the information is...

> In order to unblock that PR, I've filed a small [backport PR](https://github.com/WordPress/wordpress-develop/pull/3158) to add the `$priority` param to `wp_enqueue_block_support_styles`. In addition to that, we need to refactor all occurrences...

@tyxla, impressive work so far. It shows the power of new React APIs ❤️ Have you experimented with giving priorities to suspense calls so we could render some more critical...

> It needs to be optional because updating top-level navigation doesn't make sense in contexts like runnable code examples. Yes, that would definitely make sense only in the context of...

> What do you think of this PR which is attempting to do something similar? #41696 @jorgefilipecosta, is this PR something that is still necessary?

@tyxla, it looks like using ESM code in 3rd party packages is more complicated with Jest than we anticipated. I’m wondering what next steps we should take. As a short...

https://github.com/WordPress/gutenberg/pull/43179 should be available on npm in a few minutes. It should resolve the issue.

@tyxla, I think the regular expression used should match the last occurrence of the `node_modules` in the path in case we encounter packages installed as deep dependencies like in the...

Excellent! Thank you for providing a fix so quickly. I will publish it to npm tomorrow.

New `8.5.2` version of `@wordpress/jest-preset-default` is available on npm. I hope it resolves the issue reported.