Greg Ziółkowski

Results 179 comments of Greg Ziółkowski

> Block scaffolding exists via #88 and I think the current default is a sensible default, but a lot of us will need modern tooling. ahmadawais has already built what...

> ...maybe the `scaffold plugin` would need an option to provide a basic webpack configuration for JS-heavy plugins... ? > Really the webpack config should sit a level higher than...

I'm not quite sure if that is a similar thing, but it might be worth checking if `clock.tick(1);` could be replaced with `jest.runTimersToTime(1000);`. See https://facebook.github.io/jest/docs/timer-mocks.html#run-timers-to-time. Jest has built-in fake timers...

I have another example for you. The following file was created using Mocha + Chai + Sinon + sinon-chai before the repository was migrated to Jest. So it gives a...

Cross-commenting from https://github.com/Automattic/wp-calypso/pull/18695: > > Please let me know which cases you needed to manual fix. Would be awesome if you could create an issue here https://github.com/skovhus/jest-codemods > @skovhus it...

You can copy inline docs also from https://wordpress.org/gutenberg/handbook/blocks/generate-blocks-with-wp-cli/#create-a-block-inside-the-plugin. They are included as part of the `wp scaffold block` command.

Overall, I love the direction. Does it mean we won't run checks on commits to the main branch anymore?

> Is there a case I'm not considering? There is one that is nearly impossible to happen here because of a low frequency of commits. In Gutenberg, we had many...

I have the same issue. ### Editor view ![screen shot 2018-03-05 at 10 36 13](https://user-images.githubusercontent.com/699132/36967966-6c9a3238-2061-11e8-8a6a-036c81b55ec7.png) ### Frontend view ![screen shot 2018-03-05 at 10 35 04](https://user-images.githubusercontent.com/699132/36967972-755380f0-2061-11e8-87ad-53f1a47538fe.png) @jasmussen, I think it might...

> I've got the tests running locally but am intermittently running into timeout errors and the workflow is having issues as well. Open to any suggestions here. ``` Error: thrown:...