Greg Ziółkowski

Results 179 comments of Greg Ziółkowski

What type of breaking changes do you expect after refactoring these three constants to be set on `globalThis`? All the code will continue to work. Are you worried that tree-shaking...

I was researching options for how different bundlers replace values at the bundle time, and this [section for Rolloup](https://medium.com/stackanatomy/the-ultimate-guide-to-getting-started-with-the-rollup-js-javascript-bundler-2ebec9398656#4095) ([another article](https://www.learnwithjason.dev/blog/learn-rollup-js/)) is very similar to the approach proposed: ```js //...

I run into an issue when testing Block Bindings in the site editor - homepage template. I know that establishing a post meta connection isn’t the best choice there but...

This is a great start. Do you want it to be more tightly integrated with the monorepo? I could offer a few hints on moving some of the configurations to...

I left some comments that are related to performance optimizations. In this case, it probably doesn't matter much, but those are good practices to follow and should be straightforward to...

> And I wonder, is "Unknown source" or "No source" sufficient? I like the "unknown" more. It could be also "unsupported" or "unrecognized". Should we also use some `title` attribute...

I took the simplest approach possible and added plugin metadata to the PHP file in both templates: `es5` and `esnext`. Related code change: https://github.com/gziolo/create-wordpress-block/commit/0d3145df6e75c236e9c63ac9dcfc2990ca291b7d @bph - do you have a...

> Also my inclination would be to not force blocks to have an ID, which is really cumbersome to track, but to reference the comment ID as a block attribute...

This looks very promising. Noting that it would potentially address https://github.com/WordPress/gutenberg/issues/43743.