ProxLB icon indicating copy to clipboard operation
ProxLB copied to clipboard

`Bug`: remove `/etc/systemd/system/proxlb.service` from package

Open mbunkus opened this issue 2 months ago • 3 comments

General

Packages should not provide unit files in /etc/systemd/system; that place is for administrators to override packaged unit files.

Weighting

Score: 1

Config

irrelevant, this is about packaging

Log

irrelevant, this is about packaging

Meta

Packages should only provide unit files in /lib/systemd/system. The /etc/systemd/system hierarchy on the other hand is supposed to only be used by administrators to customize/override packaged units. Furthermore, not packaging them in /etc/… allows the admin to place their stuff in /etc/… without dpkg complaining on each upgrade that configuration files were modified & that a package provides a new version of it.

Furthermore, your package already provides a service in /lib/…, and the one in /etc/… is identical!

Just don't package one in /etc/… at all, please.

Version: 1.1.7 (the one from your build pipeline with the fix for Proxmox 8) Installed from: .deb. from your build pipeline Running as: local on one Proxmox

mbunkus avatar Oct 08 '25 09:10 mbunkus

Hey @mbunkus,

thanks for providing this and you're absolutely right and this is unfortunately a left-over from the first iterations. However, I'm planning to bring this directly into Debian (the project on Salsa is currently not public) will fix this. I'm not sure if it's worth to bring any efforts here anymore, when the whole packaging and dedicated repository might become deprecated asap.

What do you think?

Cheers, gyptazy

gyptazy avatar Oct 08 '25 11:10 gyptazy

Oh, I see. Yeah that'd be perfectly fine for me. I've set the weighting score to 1 for a reason 😁 I just thought I'd mention it here in case you weren't aware. It really doesn't have a big negative impact on users of the current package.

Feel free to close or leave open at your discretion.

mbunkus avatar Oct 08 '25 11:10 mbunkus

As it's indeed a bug, let's keep this open until it's fixed by moving to salsa.debian.org and being integrated within the official Debian repositories. This might take some time due to Debian's way of adding new packages.

Maybe it's even worth to fix it here in the meantime, but operators are still able to use override's for the unit file. So, it's not that urgent.

gyptazy avatar Oct 09 '25 07:10 gyptazy