save-in icon indicating copy to clipboard operation
save-in copied to clipboard

[Firefox] stopped saving files

Open despecial opened this issue 3 years ago • 14 comments

Worked like a charme but today, after a restart of the browser Firefox is unable to save items via the plugin. Notification only says "Crash" and download fails. Enough space is there and the symlink is working.

Any idea?

despecial avatar Apr 27 '21 13:04 despecial

After checking other websites it seems that Instagram changed their url scheme or something else is interrupting the plugin. Other sites work as before - instagram.com is failing. @gyng

despecial avatar Apr 28 '21 11:04 despecial

Is this abandonned software? Would be a pity! @gyng

despecial avatar May 06 '21 07:05 despecial

Apologies, real life is in the way :(

I'll try to spare some time in the near future to go through the backlog real soon.

gyng avatar May 06 '21 08:05 gyng

It's been a month - did you find some time to check the problem?

despecial avatar Jun 10 '21 22:06 despecial

I tried downloading from Instagram and it indeed crashes with CRASH. I believe it's a browser bug, this seems to be it: https://bugzilla.mozilla.org/show_bug.cgi?id=1633191

I've added a workaround that seems to fix it on my machine on FF Nightly in https://github.com/gyng/save-in/commit/b361b1aee8b35ef23c64ec16f325ac84db4275d2.

I also noticed Instagram has a div covering images, so you'll need to block that div using an adblocker to get the context menu working.

Thanks for the report! I appreciate that it took a while for me to look into this. Hopefully this fixes it for Instagram images with 3.5.2.

gyng avatar Jun 13 '21 11:06 gyng

Unfortunately, after more testing the bug is back: maybe I got lucky somehow. For now I can only suggest using Chrome if the bug isn't fixed.

gyng avatar Jun 13 '21 12:06 gyng

Some good news, though. I added a "Fetch via Fetch API" option that should work for Instagram. It should come with the next release.

image

gyng avatar Jun 13 '21 12:06 gyng

This option is in 3.5.3. It's not enabled by default, so you'll need to switch it on.

gyng avatar Jun 13 '21 16:06 gyng

What are the drawbacks, if any, to this Fetch API? I noticed I can save Pixiv images to two folders without having to refresh the page. I never enabled that script method because I didn't want to lose notifications.

SenpaiSharp avatar Jun 18 '21 22:06 SenpaiSharp

@SenpaiSharp Thanks for the report that it works for Pixiv. It's a fresh download of the image. I'm not sure if it passes cookies and referral headers (I didn't test), so the site could block downloads based off that.

gyng avatar Jun 19 '21 05:06 gyng

One drawback e.g. is that saving videos from IG takes up to 20-30s. So you wont see if FF is downloading it until its shown in the "downloads" list.

despecial avatar Jun 19 '21 07:06 despecial

In firefox forks this does not work (option not available)

morosakubek avatar Oct 04 '21 13:10 morosakubek

on FireDragon screen

morosakubek avatar Oct 23 '21 15:10 morosakubek

https://github.com/gyng/save-in/wiki/Filename-rewrite#add-jpg-and-mp4-extensions-to-images-and-videos-without-extensions-in-filename

mediatype: 

Doesn't work after version 3.5.0

DeadNews avatar Oct 04 '22 17:10 DeadNews