save-in icon indicating copy to clipboard operation
save-in copied to clipboard

Please add keyboard shortcut support!

Open Hlsgs opened this issue 6 years ago • 16 comments

(self explaining)

Hlsgs avatar Nov 01 '17 09:11 Hlsgs

This would be really nice. For Firefox, it's blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1320462 From that page it seems like Chrome has an undocumented feature for it. Think I'll wait for Firefox to implement it too to save me some pain later on.

gyng avatar Nov 01 '17 20:11 gyng

How about SHIFT + doubleclick as a workaround?

Hlsgs avatar Dec 03 '17 10:12 Hlsgs

Menu shortcuts landed for Chrome in 2.0.0. Right-click > a > a or Right-click > a > {1, 2, 3...} by default.

Directly clicking on the item will require injecting JS into the page, which I want to avoid if possible. Maybe if Firefox takes forever to implement accesskeys.

gyng avatar Dec 05 '17 03:12 gyng

They've landed FF's own context menu shortcuts in beta 58, but I don't think they settled on the WE API. Is this the bug to track? https://bugzilla.mozilla.org/show_bug.cgi?id=1421811

Hlsgs avatar Dec 05 '17 09:12 Hlsgs

It's the other bug, I think?

I've changed my mind on content scripts as it's going to take a while for support to land in Firefox. In 2.2.0 there's now an experimental option for clicking to save. It's disabled by default and the shortcut defaults to Alt+click. A different modifier key can be supplied.

gyng avatar Dec 26 '17 07:12 gyng

Is it possible to prevent the click from propagating through when used as part of the click-to-save feature?

Current behaviour: alt+click also zooms in / out image etc. Expected behaviour: consume the click.

FatOrangutan avatar Dec 26 '17 15:12 FatOrangutan

gyng, So where is that option exactly? Can't find it.

Sjkomy avatar Dec 26 '17 16:12 Sjkomy

@FatOrangutan Released 2.2.1 that hopefully fixes this.

@Sjkomy It's under keyboard shortcuts in 2.2.0. You might need to check for updates. screen shot 2017-12-27 at 10 08 39

gyng avatar Dec 27 '17 02:12 gyng

Perfect! It seems that it updated itself overnight otherwise i couldn't miss that EXPERIMENTAL button. Thank you, i almost feel as comfy as i was before that firefox update, and if only there was a context menu editor...

Sjkomy avatar Dec 27 '17 09:12 Sjkomy

So this doesn't seem to be working for me. Does the injection still happen in the following situation.

Page of thumbnail links to full size images, open several in new tabs. These new tabs have the full sized images only, JPG, PNG, etc... not embedded in an HTML page. Does the script injection still work in this case? When I go to those tabs try to ALT+Click nothing happens.

It would also be nice if this could also be driven by a Double Click, but the ALT+Click is a great start.

GallaherMike avatar Dec 27 '17 17:12 GallaherMike

@GallaherMike I can't replicate this. It works, but the individual tabs have to be refreshed for the script injection to work if the setting was changed after the tabs were loaded.

gyng avatar Dec 29 '17 06:12 gyng

@gyng I spotted a bug that sometimes after i open a new page every image i press is downloaded (without hotkey), refresh undoes this

Sjkomy avatar Jan 17 '18 15:01 Sjkomy

@Sjkomy Thanks, I've noticed this too. Should be fixed for the next release in cbd519b703bcc616f7f18da50b3bf5da0d4836e4

gyng avatar Jan 18 '18 05:01 gyng

@gyng please consider allowing a hotkey for each folder , for example ./images :keycode:9 , greatly saves time

Pandahisham avatar Mar 29 '18 18:03 Pandahisham

@Pandahisham It's available as accesskeys for Chrome, but it will be nice to have something equivalent for Firefox. I'll look to add it in some form.

gyng avatar Apr 02 '18 02:04 gyng

@gyng I think I failed to explain myself properly. The accesskeys still require me to manually click and open the context menu first , then hit the accesskeys . What I am proposing is allowing multiple "click to save" keycodes, each bound to a specific folder so that the user need not open the context menu. Thanks for all your effort

Pandahisham avatar Apr 02 '18 18:04 Pandahisham