grunt-bowerful icon indicating copy to clipboard operation
grunt-bowerful copied to clipboard

Support for bower.json

Open manoswerts opened this issue 11 years ago • 5 comments

Also tuned down verbosity.

manoswerts avatar May 11 '13 23:05 manoswerts

I think the if check that you added is unnecessary, but instead of using an if statement you could using an assignment like:

Var json = checkfileexistfunc ? readfile : {}

mitermayer avatar May 15 '13 21:05 mitermayer

Since we are checking for many files existances and rreading their content I think that could have own facade function wrapper.

mitermayer avatar May 15 '13 22:05 mitermayer

You're right. The code could be written more concise or extracted into a separate object / function. Quick late night contributing to make a use case work does not always result in the best code. I should take more care the next time. I will make the change in a couple of days.

I also noticed I accidentally started contributing on master instead of develop. That's ok?

manoswerts avatar May 16 '13 18:05 manoswerts

this is great adition i hope it gets merged soon

mitermayer avatar Jun 08 '13 04:06 mitermayer

bower.json is in the develop branch. Does it work for you?

gyllstromk avatar Jun 09 '13 17:06 gyllstromk