Gyandeep Singh

Results 19 comments of Gyandeep Singh

One of the big one is Webpack 4 upgrade, which is still pending (https://github.com/facebook/create-react-app/pull/4077). I used create-react-app to create my ts project (i did eject) and then i incorporated stuff...

I have realized this happens only if you use ts-loader. If you just use .js files then its fine... (I dont use babel either ways)

Thanks for the investigation and solution @danieldunderfelt . I do feel like that if this was a problem in general with webpack then using the above plugin makes sense regardless...

I think I brought up this issue inside the chat room couple of months ago. I was advised to use syntax like this ```js import m from "mithril/hyperscript"; import render...

I agree with @orbitbot above. We also use just hyperscript and render from Mithril. Also I think we should avoid including promise by default as most of the environments already...

Which I dont disagree with. But today, people who use libraries like react and mithril in production tend to use polyfill libraries. That when we have repeated code. Thats why...

This plugin is already disabled.

> If we do add this, I don't think we should put the config file in the .github folder, because it's not intended to be used by GitHub. Probot is...

> My interpretation of the .github folder is that it stores files intended to be used by the github.com website. I don't think it's relevant that we're using a tool...

I did implement this here at work as I use the same bot at work also. It works fine and it has not created any issues. I think we can...