Yang Gu

Results 29 comments of Yang Gu

Another place that has readState check is tfjs-data/src/util/test_utils.ts. I'm not sure if we need to also fix it. Given waiting for video is useful in multiple places, can we implement...

> > Another place that has readState check is tfjs-data/src/util/test_utils.ts. I'm not sure if we need to also fix it. > > I'm not sure either. Let me wait for...

This PR is still WIP. @qjia7 @xhcao PTAL to see if you have any high-level comments. Do you have a good idea to write some test cases for this?

With above changes, I get below from unit test: LOG: 'averageTime of setTimeoutWPM is 0.06666664282480876 ms' LOG: 'averageTime of setTimeout is 4 ms'

Thank you all for the comments! I think I have addressed all of them. Could you please take another look? I also tested bodypix-MobileNetV1-image-0.25 and got below data (best time,...

@pyu10055 Can you review again the latest changes? Thanks!

Thanks @vladmandic , I will investigate this.

We once did some investigation on why there is a big perf diff between WebGL data() and dataSync(). The basic finding is below: WebGLRenderingContext.readPixels() is a blocking operation. It waits...

Thanks for the quick try! It seems 4ms delay in setTimeout() contributes to most of the gap between async and sync calls. Once it's solved, I also think another gap...

@vladmandic I have a PR (under review) at https://github.com/tensorflow/tfjs/pull/6694. May I have your help to give a try? Currently the custom setTimeout is gated by an environmental variable "USE_SETTIMEOUTWPM", so...