external-sorting icon indicating copy to clipboard operation
external-sorting copied to clipboard

Cleanup tmp files after running

Open cmdcolin opened this issue 4 years ago • 1 comments

Hi there

Great library! Just what was needed :)

I was wondering if this library can clean up the files it outputs to the tmp dir?

If you use https://www.npmjs.com/package/tmp

You can call tmp.setGracefulCleanup() and it will automatically cleanup files it created in the process of running

cmdcolin avatar Aug 16 '21 20:08 cmdcolin

Also I haven't really debugged it but the maxHeap parameter might have too-high-default-value

If I use the 1MB maxHeap that is in the README example for the package, it is seems to be much faster than the 1GB

cmdcolin avatar Aug 16 '21 20:08 cmdcolin