social-feed-manager icon indicating copy to clipboard operation
social-feed-manager copied to clipboard

review create_conf_file for error handling

Open dchud opened this issue 10 years ago • 4 comments

Probably need at least a try/catch block around file operations.

dchud avatar Jun 03 '14 17:06 dchud

Work should be done along with #164.

dchud avatar Jul 15 '14 18:07 dchud

Ignore previous comment about #164; will handle separately.

dchud avatar Aug 17 '15 17:08 dchud

@dchud Upon looking into this... the file operations errors would occur within the model's post_save method, but outside of the context of admin, there is no longer a request to attach the error message to, if we'd like it to show up in the admin screen.

To do this properly, it looks like we need to do some rearranging and move the guts of the post_save method into admin save_model(). That's probably where it belongs anyway. May want to do something similar with the post_delete method. The only place we expect TwitterFilters to be created or deleted is from the Admin screen, at least in this incarnation of SFM.

Let's discuss whether this concept is on or off-target, and whether the code disruption is warranted for m5_004, or not.

kerchner avatar Sep 21 '15 01:09 kerchner

Moving out of scope for m5_004 - shouldn't prevent a properly-configured environment from working.

dchud avatar Sep 21 '15 21:09 dchud