sledge-serverless-framework icon indicating copy to clipboard operation
sledge-serverless-framework copied to clipboard

Published 20 hours ago • verified publisher icon gwsystems

Solve partial builing and running issues for ARM machines

Open lyuxiaosu opened this issue 2 years ago • 2 comments

Resolves #169

This PR includes the following changes:

  • Modified the assembly code for ARM to fix the assert failure of sandbox state
  • assert(now > sandbox->timestamp_of.last_state_change) in sandbox_set_as_initialized.h failed in ARM machine because now is equal to sandbox->timestamp_of.last_state_change, so modity the assert to assert(now >= sandbox->timestamp_of.last_state_change)
  • Add TODO of finding another way to get CPU speed for ARM machines in main.c

lyuxiaosu avatar Mar 23 '22 04:03 lyuxiaosu

Good work here! I'm sure this was a ton of work to figure out. I left a few nit comments and had a few follow-on questions. I noticed the linter is failing on auto-format. Please run ./format.sh before you push to GitHub, and this should pass. I run ./format.sh for the three changed files, but nothing was changed. After running the scripts, no these files are changed. I don't know why.

lyuxiaosu avatar Apr 05 '22 20:04 lyuxiaosu

@lyuxiaosu - Don't worry about the formatting. I'm happy to push a commit dealing with that once everything else is addressed. Let me know if you have any other questions!

bushidocodes avatar Apr 06 '22 00:04 bushidocodes

This needs further detailed look if necessary in the future. Closing for now.

emil916 avatar May 27 '24 21:05 emil916