composite icon indicating copy to clipboard operation
composite copied to clipboard

Slm

Open gparmer opened this issue 3 years ago • 0 comments

Summary of this Pull Request (PR)

Initial slm implementation that is designed to

  1. simplify the current sl codebase by removing hierarchical scheduling,
  2. removing allocation from the core code, and
  3. decomposing the system into modules more cleanly.

This is a work in progress, and the tests are in implementation/tests/slm/main.c. Trello encodes many of the next steps, but they include:

  1. getting multicore working again which involves bootup, and communication (queues, and asnds),
  2. determine the proper design of the periodic blocking API,
  3. adding the blockpoint logic, and
  4. test the heck out of it with existing tests.

Intent for your PR

Choose one (Mandatory):

  • [x] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
  • [ ] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)

@WenyuanShao @msdx321 @betahxy

Code Quality

As part of this pull request, I've considered the following:

Style:

  • [x] Comments adhere to the Style Guide (SG)
  • [x] Spacing adhere's to the SG
  • [x] Naming adhere's to the SG
  • [x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
  • [x] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

  • [x] I've made an attempt to remove all redundant code
  • [x] I've considered ways in which my changes might impact existing code, and cleaned it up
  • [x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
  • [x] I've commented appropriately where code is tricky
  • [x] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

  • [x] slmtests

gparmer avatar Jun 16 '21 17:06 gparmer