nlmod icon indicating copy to clipboard operation
nlmod copied to clipboard

Notebooks are not tested during CI

Open bdestombe opened this issue 3 years ago • 5 comments

I thought this was the case before. Please have a look at the dtscalibration package if you experience any issues with the implementation.

bdestombe avatar Mar 29 '22 08:03 bdestombe

Yes I removed these tests because they took so long. They are explicitly excluded in ci.yml using py.test ./tests -m "not notebooks".

We can reinstate them but I think we should first improve test efficiency (see also #21).

OnnoEbbens avatar Mar 29 '22 12:03 OnnoEbbens

Ah I see. What about the following two options?

  • start two CI pipelines in parallel. One with the notebooks and one with the other tests. While developing only look at the latter one and requiring both for a version bump. I recon it is even worthwhile paying for two CI sessions.
  • Moving the notebook tests to the end of the CI.

bdestombe avatar Mar 29 '22 12:03 bdestombe

Onno and I discussed over the phone that I would look into the possibilities of having two parallel pipelines

bdestombe avatar Apr 13 '22 07:04 bdestombe

Solve together with #21

OnnoEbbens avatar Aug 24 '23 08:08 OnnoEbbens

The notebooks are not tested directly, but readthedocs does run then before publishing them on nlmod.readthedocs.io, where its output can be checked.

rubencalje avatar Nov 06 '24 13:11 rubencalje