Glen Whitney

Results 267 comments of Glen Whitney

Wow, yes, I haven't even submitted that as a PR yet. Thanks for your interest in it. I think it's pretty much ready, but there is one hitch, that detect-indent...

I plan to update/reimplement this on current mathjs, according to the precedence and other details as discussed.

Well, at first glance, to get the same effect/ability that Matt is after while avoiding the drawbacks of adding code to every Node class that will only be used by...

> (Glen I think you mean `src/function/algebra/resolve.js` instead of `src/function/algebra.js` in your first bullet point btw) Indeed, fixed.

Well the best way to describe is to do, so I can go one better and just provide #2801 that implements my suggestion. And the new test I added for...

The "overriding three signatures" thing is because typed-function doesn't allow optional arguments. I don't see why this architecture/leveraged use of typed-function should be penalized because of that. But based on...

OK, I went ahead and rearranged the implementations in #2801 so that to add any new node type, you only have to supply the `NewNodeType, Map|undefined|null, Set` signature. (It has...

I must admit I am confused about the current handling of complex infinities/NaNs both in mathjs and complex.js, as there seem to be lots of open issues and PRs on...

I have so many assigned to me now, and I tried to make it clear above that I do not see myself as being able to handle this one on...

Thanks for the detailed report! The only thing I am unsure of is the exact specification of the unit "language" that Unit is designed to handle. Your examples work in...