vfg-field-object icon indicating copy to clipboard operation
vfg-field-object copied to clipboard

Propagate and generate model-update events

Open k8n opened this issue 5 years ago • 2 comments

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix

Does this PR introduce a breaking change? (check one)

  • [X] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the develop branch (or to a previous version branch), not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] All tests are passing
  • [ ] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I'm unable to build the project; broke my head on this:

src/index.js → dist/vfg-field-object.esm.js...
[!] (vue plugin) Error: Unknown transform 'collections'
src/components/field-object.vue
Error: Unknown transform 'collections'

Help?

k8n avatar May 13 '19 16:05 k8n

This is a real issue. Is it possible to validate this PR soon please ?

fugudesign avatar Feb 17 '20 09:02 fugudesign

@k8n, you can upgrade the node module "rollup-plugin-vue" to 5.x.x version and then you may have to switch the babel plugin order, babel should be before commonjs. Works for me.

fugudesign avatar Feb 17 '20 12:02 fugudesign