jquery.sparkline icon indicating copy to clipboard operation
jquery.sparkline copied to clipboard

html validation fails

Open gcphost opened this issue 10 years ago • 2 comments

Hi

I like the tag option method but it renders invalid html, could these be changed to data tags please?

line 103: Attribute sparkheight not allowed on element span at this point. line 119: Attribute sparkbarcolor not allowed on element span at this point

data-spark-height data-spark-bar-color

etc

gcphost avatar Apr 21 '14 20:04 gcphost

I just encountered the same. Using invalid attribute names is extremely bad practice; this is a major bug.

cburschka avatar Nov 10 '16 09:11 cburschka

the library seems to be inactive now. I have started to try to implement some changes in https://github.com/timelyportfolio/jquery.sparkline. If you are interested in making a pull, please let me know.

timelyportfolio avatar Nov 10 '16 15:11 timelyportfolio