pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

add zero-noise PE example for LISA

Open WuShichao opened this issue 1 year ago • 2 comments

Standard information about the request

This is a: doc update

This change affects: inference, doc

This change changes: documentation

Motivation

In the current PyCBC Doc, it seems there are no zeroNoise examples for PE. Also, someone asked how to perform LISA PE with zero noise injection while still passing extra arguments to PSD functions in the likelihood calculation.

Contents

Add code to show how to use psd-extra-args with psd-model, when fake-strain = zeroNoise.

Testing performed

zero noise lisa_smbhb_mass_tc noise lisa_smbhb_mass_tc_noise

Additional notes

  • [x] The author of this pull request confirms they will adhere to the code of conduct

WuShichao avatar Sep 29 '24 16:09 WuShichao

@ahnitz Can we merge it?

WuShichao avatar Apr 09 '25 18:04 WuShichao

@WuShichao Shouldn't it be a separate example rather than overwriting the existing one? I know you left stuff in the comments, but I think a separate file would be better. Otherwise, if this works after that then you are good to go.

ahnitz avatar Apr 09 '25 18:04 ahnitz