pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

fir_zero_filter rolls data too far by -1

Open matijsv opened this issue 1 year ago • 1 comments

The function is supposed to correct the phase shift caused by using the filter, but it over-rolls by -1 datapoint. Easily fixed by calling .roll(1) after, on the affected timeseries

matijsv avatar Aug 23 '24 21:08 matijsv

@matijsv Can you provide a minimal example? Also are you willing to submit a PR to address the issue?

ahnitz avatar Aug 26 '24 23:08 ahnitz