pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

PyGRB injection finder/combiner fixes

Open jakeb245 opened this issue 4 months ago • 1 comments

This PR fixes a bug in pycbc_grb_inj_finder that caused the entire output dataset to be empty. It was a logical error in checking the datasets to merge. This does seem to cut the search and gating sets. These should be copied to the final output at some point.

An exception will also be raised in the event of pycbc_grb_inj_combiner receiving zero valid input files. This is to avoid the injection sets having improper names. We were calling them "NSXXTEST" but they should be called "NSXX30INJ" where the number is the max inclination.

jakeb245 avatar Mar 07 '24 14:03 jakeb245

@jakeb245 you should rebase this branch on master to pick up a fix for the failing checks.

titodalcanton avatar Mar 08 '24 17:03 titodalcanton