pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

added support for mode-by-mode decomposition of NRHybSur3dq8 waveform…

Open lpathak97 opened this issue 2 years ago • 2 comments

lpathak97 avatar Oct 05 '23 18:10 lpathak97

@lpathak97 You don't need to close and reopen pull request to change what is in them. The PR reflects the latest state of the branch, so whatever you change in the branch will be reflected automatically. So if you accidently commit a file, you can just revert that or go back to the old version and then push the new version to github without the extra commits.

ahnitz avatar Oct 05 '23 18:10 ahnitz

Only two issues remain, which are related to duplication.

lpathak97 avatar Oct 05 '23 18:10 lpathak97

@lalit-pathak I think you may have rebased tbe wrong way. You want to use gwastro/master as the base and have your commits on top, not the other way around. (also avoid merge commits)

ahnitz avatar Mar 13 '24 05:03 ahnitz