pycbc
pycbc copied to clipboard
gwastro
Rework trigger file finding in pycbc_live_single_trigger_fits
Use gps start and end times to find files for triggers, rather than a single directory where we find all files
This should be something fairly easily changed in future to allow us to use file attributes rather than filenames
~Long term thing, not needed for O4 analysis~ Needed for the trigger collation script
All output datasets are the same to within a numpy.isclose, some are re-ordered but the same once sorted. Keys change, but that is largely in the addition of fit-start and fit-end, as well as the input as arguments have changed
Might be worth rebasing this given all the work that has happened in the mean time.
I've rebased and added some changes to this.
Mainly the changes are to move the argument parsing into functions in a module so they can be reused in https://github.com/gwastro/pycbc/pull/4697
All output datasets are the same to within a numpy.isclose, some are re-ordered but the same once sorted. Keys change, but that is largely in the addition of fit-start and fit-end, as well as the
inputas arguments have changed
This is still the case with the updates since the rebase, for more concrete discussion of changes
- pruned_trigger_times has changed order
- All datasets under the triggers group change order
- attributes fit-start, fit-end have been added, and analysis_date is removed
- fit_coeff datasets change by small amounts (<1e-4)
Ive realised that this will need an update to the supervisor script, which I will add in the next day or so
@titodalcanton Could you have a quick look over the changes Gareth has made to the supervise scripts? Then hopefully this can be merged 😁
I think the remaining codeclimate complaints are previously-existing problems
Didnt realise I hadn't re-requested review from @titodalcanton, oops!