pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

allow multiple cuts on same parameter

Open GarethCabournDavies opened this issue 1 year ago • 1 comments

Amend cuts module to allow multiple upper/lower cuts on the same parameter, also check and deal with duplicated cuts.

This is done by updating the cuts dictionaries to be keyed on parameter and the comparison function, rather than the parameter only.

Solves #4146

GarethCabournDavies avatar Oct 04 '22 10:10 GarethCabournDavies

I'm struggling to review this, as I haven't seen this code before, and can't really tell what it is supposed to do or how it fixes the problem. Could we add a few simple units tests (or a single unittest code in /test) to illustrate and test what this module is doing?

spxiwh avatar Oct 04 '22 15:10 spxiwh