pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

Offline singles BIG changes

Open GarethCabournDavies opened this issue 2 years ago • 3 comments

Changes for the including singles into the offline search as described in the paper by myself and Ian

In the same vein as the way that the multiifo search was kept separate until it was more stable, I've tried to keep everything as a different search, but obviously there is a lot which is reused

I've tried to add a small search test as well, as a result, I think we need to have the PR up, though this is draft at the moment until I can convince the tests to work

GarethCabournDavies avatar Mar 16 '22 15:03 GarethCabournDavies

Diffs for the ini files between singles_search and search directories:

ini_files_diffs.txt

GarethCabournDavies avatar Mar 28 '22 15:03 GarethCabournDavies

diff for the search and singles search workflow files:

diff .github/workflows/search-workflow.yml .github/workflows/sngls-search-workflow.yml 
1c1
< name: run small search using pegasus + condor
---
> name: run small singles-included search using pegasus + condor
41,42c41,42
<         cp examples/search/*.ini ./
<         bash -e examples/search/gen.sh
---
>         cp examples/singles_search/*.ini ./
>         bash -e examples/singles_search/gen.sh

GarethCabournDavies avatar Mar 28 '22 15:03 GarethCabournDavies

My testing was slightly wrong, so I need to re-draft this and will mark as ready again soon. Sorry for any kerfuffle

GarethCabournDavies avatar Mar 29 '22 09:03 GarethCabournDavies

@GarethCabournDavies Is this PR now defunct? Or still on the backburner?

ahnitz avatar Aug 23 '22 15:08 ahnitz

PR is now defunct, sorry - it was a collection of what I'm trying to do in a more modular/ easily reviewable way (i.e. the just-approved sngls statmap PR)

(up next will be results plotting and workflow)

GarethCabournDavies avatar Aug 23 '22 15:08 GarethCabournDavies