pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

improve interoperability for PyCBC in external waveform packages

Open ahnitz opened this issue 3 years ago • 2 comments

PyCBC has as one of its key goals the idea of providing a simple interface for GW waveform generation which can be used by humans, but also higher level algorithms such as searches and parameter estimation.

To help aid with this, we've added a plugin architecture so that external waveform packages can advertise and export a compatible interface, allowing PyCBC to recognize its capabilities and automatically be able to use its waveforms if the package is installed.

We should consider adding support in the following external packages (some such may have explicit support already, but probably should move to plugin model).

  • [x] gwsurrogate (https://github.com/sxs-collaboration/gwsurrogate/pull/29)
  • [x] teobresum
  • [ ] lalsuite
  • [ ] seobnre
  • [ ] python imrphenom

ahnitz avatar Jun 30 '21 11:06 ahnitz

A possible error related to waveform plugin #3750

yi-fan-wang avatar Jul 14 '21 22:07 yi-fan-wang

A PR has been submitted for gwsurrogate to add integration https://github.com/sxs-collaboration/gwsurrogate/pull/29

ahnitz avatar May 10 '22 15:05 ahnitz