pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

SNRIFAR plots for multi-ifo file format

Open tdent opened this issue 4 years ago • 7 comments

The SNRIFAR plot will need to look in various different paths/datasets to find backgrounds for the multiifo search. This could be dealt with by telling the plotting code where to look in the file (with a sensible default).

tdent avatar Oct 04 '19 13:10 tdent

Note that this change should mean that we can use the pycbc_multiifo_add_statmap file output as well as the existing use, which will use the coinc_statmap or exclude_zerolag outputs

GarethCabournDavies avatar Oct 07 '19 14:10 GarethCabournDavies

Is this still open?

tdent avatar Apr 08 '20 15:04 tdent

Sorry. Somehow I had forgotten about it. I will do it this week. Thanks for reminding.

khunsang avatar Apr 10 '20 08:04 khunsang

How is this going?

GarethCabournDavies avatar Nov 12 '20 12:11 GarethCabournDavies

I don't know what this was supposed to do besides produce the 'FAR vs rank' plots in the closed and open boxes, which now exist for multiifo due to a bunch of previous commits.

tdent avatar Nov 12 '20 13:11 tdent

I wasnt sure if we were planning on making it possible to run SNRIFAR with add_statmap output, or if we did this already. If everything is good, we can close the issue

GarethCabournDavies avatar Nov 12 '20 13:11 GarethCabournDavies

I don't know if that is wanted and I don't know if it has been done, so I certainly don't know if everything is good.

In any case the task, if there is one, needs a bit more definition.

tdent avatar Nov 12 '20 13:11 tdent