pycbc icon indicating copy to clipboard operation
pycbc copied to clipboard

The workflow generators should write a veto definer file for reproducatibility

Open duncan-brown opened this issue 7 years ago • 4 comments

If the veto definer file contains a segment type with a zero end time, then it is possible that two runs of the workflow will not produce the same results if someone has changed the segments in the database.

For reproducibility, the workflow generator should write out a veto definer file with start and end times populated based on the segment summary table in the database at the time the workflow is built to allow reproducibility.

duncan-brown avatar Feb 28 '17 13:02 duncan-brown

@duncan-brown This seems like a good idea. Is it worth actually having a check, like Ian has done for a lot of other segment issues, that sees if the veto has been defined for the entire period of the analysis?

ahnitz avatar Feb 28 '17 13:02 ahnitz

Is this still an issue?

tdent avatar Oct 09 '20 14:10 tdent

I don't think this is an issue anymore. There are ways to track which veto-definer is used.

lauranuttall avatar Oct 09 '20 15:10 lauranuttall

@lauranuttall @duncan-brown If you don't think it's an issue, please close.

tdent avatar Oct 09 '20 16:10 tdent

Closing due to inactivity / @lauranuttall thought this wasnt an issue a couple of years ago

GarethCabournDavies avatar Sep 13 '23 08:09 GarethCabournDavies