GW2-Addon-Manager icon indicating copy to clipboard operation
GW2-Addon-Manager copied to clipboard
verified publisher icon gw2-addon-loader

Fixing Disable and Re-enable not working fixes #167

Open Regan-Dryke opened this issue 4 years ago • 3 comments

Correcting bugs that prevented the Disable and Enable option from working.

Using addon_name was never equal to the name in the AddonsList creating a scenario where disable and enable were never executed properly.

Added some conditions to handle disabling arcdps also disabling all other arcdps modules and same for re-enabling. (Should probably come back to redo this part as I think it doesn't handle some cases.)

Note: The delete option should probably be looked at.

Regan-Dryke avatar Mar 15 '22 22:03 Regan-Dryke

Tested this PR and the disable/re-enable works (as it doesn't work with current master branch version), it would be nice to get this PR merged. Tagging @Friendly0Fire in case this PR got lost in the notifications

jackpoz avatar Aug 23 '23 20:08 jackpoz

any feedback on why this is not merged yet?

speedyconzales avatar Oct 01 '23 10:10 speedyconzales