advanced-http4s icon indicating copy to clipboard operation
advanced-http4s copied to clipboard

[WIP] Update dependencies

Open guizmaii opened this issue 7 years ago • 5 comments

Hi @gvolpe,

How are you since the ScalaIO ? :)

While writing my first http4s project, I found your project which helped me to understand a lot of things ! I'm using the 0.20.0-M4 version of http4s so I tried to update your project dependencies.

One important remark concerning this update is that I wasn't able to use TaskApp where it were use. IIRC, it lacks the Timer instance and I'm not sure how to bring it.

EDIT: The work is done IMO. I'll let the [WIP] in the title for some time. I need to sleep a bit on this PR before submitting it to you. Feel free to take a look and comment if you want, ofc. 🙂

guizmaii avatar Dec 28 '18 15:12 guizmaii

Hey @guizmaii , I'm great, thanks for doing this :) I'll review it shortly before I go on holidays!

gvolpe avatar Dec 29 '18 01:12 gvolpe

Oh, the README file needs to be updated too. Specially references to package names such as fs2.async.

gvolpe avatar Dec 29 '18 02:12 gvolpe

Hey @gvolpe,

As promised, I worked today on your remarks. I made all the changes you requested.

There's still work to do on the Multipart client and server. None of them works correctly. The client seems to generate invalid requests. And the server uses a fs2 function named writeAll which makes everything crash.

It's a bit late here now. I'll go drink a beer or two. Not sure I'll have the time to work on this until next weekend.

See you 🍻

guizmaii avatar Jan 05 '19 18:01 guizmaii

@guizmaii I forgot to mention that all the http4s examples are also part of the official examples (I submitted a PR long time ago) and can be found here. I believe that since it is in master it is up to date so might be worth having a look :smiley:

gvolpe avatar Jan 07 '19 09:01 gvolpe

A funny thing to notice is that they use the Scala global EC in store https://github.com/http4s/http4s/blob/master/examples/blaze/src/main/scala/com/example/http4s/blaze/demo/server/service/FileService.scala#L42

:)

guizmaii avatar Jan 07 '19 13:01 guizmaii