FreehandRasterGeoreferencer
FreehandRasterGeoreferencer copied to clipboard
gvellut
crash with projects using relative paths in v0.8.3
Here is a a diff of a fix for a crash I started seeing after updating to the latest version of the plugin. The issue is that the layer initialization module got confused between absolute and relative paths. Or at least this version started working after I changed the code to explicitly pass around the absolute image path. The crash was happening in the gdal_utils methods when they tried to open the file with a relative file path. I hope this is helpful. abspath-patch.txt
You are quite welcome.
I’d like to ask a related question. I’ve been happily using your plugin for quite a while. At some point (when I was trying to align about a dozen and a half orthos), I added keyboard short cuts for the map tools I use most frequently - move, adjust and increase/decrease transparency. I find the keyboard shortcuts much faster and more precise when I have to make a large number of small changes (one pixel in most cases).
I’m adding more because I’m into another round of such work.
Would you like to look at what I’ve done? It isn’t much but it’s about 600-700 lines of code. If you like the idea, we can conspire to wind up with keyboard assignments, etc that will blend harmoniously with your overall ui? I’m not sure that a pull request is quite the right way to communicate now because I don’t want others to take the not quite ready for prime time code and try to use it. But if that is easier for you I can certainly create the pull request.
One reason to get your feedback is that I’m getting to a point where I’d like to do some code restructuring - for example splitting the map tools into separate files - anticipating taking a shot at implementing the FRG in C++ and submitting it to the “main” qgis project. In my dreams.
Stephen
On Jun 25, 2021, at 2:35 PM, Guilhem Vellut @.***> wrote:
Thank you. I will test and merge it soon.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
Sure. You can send me a diff and I will have a look. But a pull request could be fine too since I am not sure if a lot of people will see it anyway...