response_locations Config spread to Deserializer

[Pierozi]

Hello,

I've been stuck a while before understanding the custom locations was not declared into Deserializer it seems the config was not parsed.

Config key named response_locations as the GuzzleHttp\Command\Guzzle\GuzzleClient constructor comment expect

• response_locations: Associative array of location types mapping to
• ResponseLocationInterface objects.

[Pierozi]

Hi @Konafets Did you think you had time to look at this PR within the next month? I would rather to not put my fork on packagist only for composer dependency installation issue.

Thanks

[Konafets]

Hi @Pierozi,

I can not promise, but will try to have a look to your patch. Meanwhile you can add the url of your fork to your composer.json. Composer will fetch your package instead of this.

https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository

[Pierozi]

Hello @Konafets, thanks for your consideration.

The issue related to composer is the project using an SDK using guzzle-services. So if I put my repo in SDK it's ok, but not for the first project.

but it's ok, the project related currently builds in PHAR, so instead of advice user to install through composer, we will recommend downloading the PHAR, as we control the build we can implement repository.

Thanks.

[Pierozi]

Any contributor want to review this one?

[Konafets]

May I ask you to provide a UnitTest which reflect your initial issue and shows how your patch fix this. Thanks!

[Pierozi]

Hello, there is the unit test to reflect the implementation of Custom ResponseLocation. I've also already rebase the PR on master to be up to date.

[Pierozi]

Hello There, any chance to have some progress here?

[GrahamCampbell]

Are you able to rebase this and revert the package rename?

[Pierozi]

Seriously 4 years after... It has been the last time I touch PHP, did the PR still make sens in the today codebase?

[GrahamCampbell]

Sorry this took so long to get to, I only took over maintenance of this package in the last couple of years, and the plans for it are just to keep it compatible with new PHP versions and new Guzzle versions. I'm not sure either you nor I want/ned this feature any-more/have the time/head-space to do anything with this PR, and so I'm going to go ahead and close this out for now. If you feel differently, please let me know.