command icon indicating copy to clipboard operation
command copied to clipboard

Fix Guzzle error processing with http_errors=true

Open savchukoleksii opened this issue 3 years ago • 3 comments

When Guzzle option http_errors=true this errorResponses not processing and this code skipped during exception: yield $this->transformResponseToResult($response, $request, $command); This fix allow errorResponses mappings from Description. If error not found in errorResponses than Guzzle error will propagate.

savchukoleksii avatar Nov 03 '21 21:11 savchukoleksii

@GrahamCampbell Done

savchukoleksii avatar Nov 04 '21 23:11 savchukoleksii

Could you add a unit test please? Then I'll be happy to merge.

GrahamCampbell avatar Nov 05 '21 09:11 GrahamCampbell

@GrahamCampbell sorry, have not time for continue this pr. Can you help me with tests?

savchukoleksii avatar Nov 26 '21 18:11 savchukoleksii

I don't have any capacity for this. I think we just need to say that that we require people not use that mode.

GrahamCampbell avatar Apr 18 '23 08:04 GrahamCampbell