Guzman

Results 20 comments of Guzman

fix(VM): remove codes.Internal from retryable gRPC errors

Not a good approach (see discussion). Follow up: https://github.com/stackrox/stackrox/pull/17637

refactor(retry): extract gRPC retry logic to shared package

> * The new shared retry logic no longer retries on codes.Internal (which was previously retriable) – please confirm that dropping Internal retries is intentional. That was a bug. Moved...

refactor(retry): extract gRPC retry logic to shared package

/retest

refactor(VM): Split logic inside handleVsockConnection

This change is part of the following stack: - #17255 - #17243 - #17320 - #17328 ◀ - #17595 - #17526 Change managed by [git-spice](https://abhinav.github.io/git-spice/).

refactor(VM): Split logic inside handleVsockConnection

> Hey there - I've reviewed your changes - here's some feedback: > > * Add a unit test for the full handleVsockConnection path when sendReportToSensor errors out, to validate...

refactor(VM): Split logic inside handleVsockConnection

> * validateReportedVsockCID uses fmt.Errorf for mismatches; consider switching to errors.Wrapf (or a similar wrapper) so you preserve stack traces and keep the error‐handling style consistent with the rest of...

refactor(VM): Split logic inside handleVsockConnection

/retest-required

refactor(VM): Split logic inside handleVsockConnection

> Are the UI changes part of this PR? The relay changes look good to me. Oops, my hackathon project lurked in here. Fixed, thanks for noticing!

refactor(VM): Split logic inside handleVsockConnection

/retest-required

refactor(VM): Extract vsock-related functionality from relay.go

This change is part of the following stack: - #17255 - #17243 - #17320 - #17328 - #17595 ◀ - #17869 - #17526 Change managed by [git-spice](https://abhinav.github.io/git-spice/).