guyzmo

Results 113 comments of guyzmo

@hhenkel Brilliant! Just need the PR listing/creation/close/comment API and it's going to be 👌

BTW, if I may comment on the API structure, it's better to use a more RESTful structure: * `/api/v1/{user}/{repo}/pullrequest` - `GET`: (with `?status={open/closed}&id={id}` params) retrieves (and filters) the list of...

This is a good idea, as from my experience implementing git services APIs, I have to admit github API is a very good one (whether you name it `pull`, `pulls`...

for the note: testing with travis won't work as we've got to spawn a full VM with many services. Memory requirements with travis are ridiculously low. The best alternative I...

I implemented rotation outside of the lib by doing something like this: given the ref to an image: ```typescript const imageRef = useRef(null) ``` I implemented and exposed the following...

cf referenced ticket, there I suggest a patch. The fix does work for me.

now it correctly handles the curly brackets, for color matching (i.e. in picture, you now have `Line 4, Char 5` in bold and `Expected…` in regular.)

Hi! thank you for the PR! I'm not sure how both can be supported :-/ But I'd rather avoid code duplication, so i'll ask around.

maybe an option would be to make a vim function

> One problem is that I think that Notifications never get cached. I searched, but `ancs_notification_list_push(notif);` never gets called. I tried adding it [here](https://github.com/guyzmo/avr_nrf_ancs_library/blob/master/ancs_lib/ancs_notification_source.cpp#L253). Yup, you've found the right spot!...