FullPageOS icon indicating copy to clipboard operation
FullPageOS copied to clipboard

Signage mode not extracting serial

Open masseelch opened this issue 4 years ago • 0 comments

What were you doing?

Starting chromium in signage mode like described in start_chromium_browser.

What did you expect to happen?

The {serial} in the url i defined gets replaced with the devices serial.

What happened instead?

The serial is empty.

Was there an error message displayed? What did it say?

There was no error.

Version of FullPageOS?

Custom build of 8e0aba274cf187784f4ab4e67ce795781771e437

Screenshot(s) showing the problem:

Not needed

The alternative line starting chromium in signage mode (reloading on errors) uses --app=$(head -n 1 /boot/fullpageos.txt | sed -e "s/{serial}/${SERIAL}/g") while the standard mode uses --app=$(/home/pi/scripts/get_url).

Changing --app=$(head -n 1 /boot/fullpageos.txt | sed -e "s/{serial}/${SERIAL}/g") to --app=$(/home/pi/scripts/get_url) results in the correct behaviour.

If there isn't something i am missing the second line should call the get_url script too. I can provide a pull request if needed.

masseelch avatar Dec 23 '20 09:12 masseelch