CustomPiOS icon indicating copy to clipboard operation
CustomPiOS copied to clipboard

Variables are not escaped properly

Open TheAssassin opened this issue 8 years ago • 2 comments

While creating #8, I fixed some of the variable occurrences with improper escaping. The scripts should be revised, and the variables should be escaped appropriately. This is probably quite some work, but should prevent the usual annoyances (like "there must be no space in the paths" etc.).

TheAssassin avatar Oct 13 '17 23:10 TheAssassin

Would appreciate it if anyone wants to take this endeavor. It sorta works for me and there might be there someone who is better in Bash coding conventions. @shlomif I remember you were pretty good at it. If you have any pointers that would be appropriated.

guysoft avatar Oct 13 '17 23:10 guysoft

@guysoft : see http://shlomif-tech.livejournal.com/14671.html and http://perl-begin.org/topics/security/code-markup-injection/ .

shlomif avatar Oct 14 '17 11:10 shlomif