ion-autocomplete icon indicating copy to clipboard operation
ion-autocomplete copied to clipboard
verified publisher icon guylabs

hotfix for css cardinality bug

Open BioPhoton opened this issue 9 years ago • 4 comments

this is a hotfix for some ionic defaults that override the ion-autocomplete stylings if we reference css order in index like following:

  1. lib.bundle.css => all css files in lib bundled together and minified
  2. app.bundle.css => all css files that are app depending (starting with ionic bundle) bundled together and minified

BioPhoton avatar May 16 '16 13:05 BioPhoton

Coverage Status

Coverage remained the same at 75.882% when pulling 0541d9556d22b5c31bd37e63785cc73fd182d626 on BioPhoton:patch-1 into 5f10460426637299960288e2109028a865eee7c6 on guylabs:master.

coveralls avatar May 16 '16 13:05 coveralls

Hi @BioPhoton,

thanks for creating the pull request! Could you maybe execute the grunt build task such that the dist folder also gets updated? Then I can merge it with the master easily.

Thanks a lot and regards,

Guy

guylabs avatar May 17 '16 05:05 guylabs

Hi @BioPhoton,

I just moved this to 0.4.0 as there was no update from your side. Is this still needed in the Ionic 1.3.x version?

Thanks and regards,

Guy

guylabs avatar Oct 27 '16 08:10 guylabs

Hi @BioPhoton

could you maybe test this with the latest master if this is still needed? As there we now use the Ionic 1.3.2 version.

Thanks and regards,

Guy

guylabs avatar Feb 23 '17 22:02 guylabs