Guy Harris

Results 604 comments of Guy Harris

> No, it's not one of the 4 protocols for which libpcap assigns a specific link type, but rather one of the remaining 25 for which it doesn't. Then perhaps...

> I mean, they _are_ Ethernet packets, and comply to all Ethernet packet rules. By which you presumably mean "they are blobs of bytes that, somewhere within them, contain an...

> Arguably, if the frame was Ethernet, the hardware and the kernel would both handle it as Ethernet. If they both handle it as DSA, then most likely it is...

Yes, I'd already read the part of the DSA documentation about the three tag types. For type 1 tags, such as `LINKTYPE_DSA_TAG_BRCM_PREPEND`, programs reading those packets will not dissect *anything*...

> > Currently: > > we have LINKTYPE_/DLT_ values for "brcm", "brcm-prepend", "dsa", and "edsa", which is as it should be, as they're either type 1 or type 2 without...

> Ok, but confusingly you refer to type 2 tags with no usable EtherType as if there was any tag at all whose EtherType is in the IANA 802 numbers...

Is "sja1105" just a standard VLAN tag if it has an Ethertype of 0x8100? 0xdadb doesn't appear to be in the IEEE database. Are "lan9303", "ocelot-8021q", and "vsc73xx-8021q" all standard...

Of the non-8100 Ethertypes: - 8874 is assigned to Broadcom, so the only question is whether it's also used for any on-the-Ethernet protocols - Wireshark already dissects it as a...

> The value of 0xdadb is self-assigned, no guarantee there won't appear a protocol using this EtherType in the future. So it's probably best to assign a `LINKTYPE_`/`DLT_` for "sja1105"...

> What does this all mean for this patch? My inclination right now is to expand the table of known tag types to include all he ones currently used in...