Guy Harris

Results 637 comments of Guy Harris

Given that we use neither `DES_cbc_encrypt()` nor `AES_cbc_encrypt()`, we shouldn't check for either one. We currently use `EVP_CIPHER_CTX_new()` *if* it's present, and use `calloc()` to allocate a `EVP_CIPHER_CTX` if it's...

Apparently `EVP_add_cipher_alias()` [was never documented and "[is an internal macro] and not really suitable for the Brave New Provider World"](https://github.com/openssl/openssl/issues/11715#issuecomment-2164442688). At least as far back as OpenSSL 0.9.6, `EVP_add_cipher_alias(n,alias)` expands...

Unfortunately, OpenBSD 7.5's libressl doesn't have `OBJ_NAME_add()`, either.

> failed to find cipher algo 3des What happens if you replace "3des" with "DES3" (all caps) in the appropriate file in TESTS.

So we now do the mapping of "3des" to a supported name for triple DES in tcpdump rather than attempting to set up "3des" as an alias for the triple...

> This fix will need a change log entry at some point. Backported to the 4.99 branch in 87b050965700b9b35f196d3774d004f8ce92d749, and added to the 4.99 section in CHANGES in both the...

You should probably link to https://holden.asger.xyz/wiki/Holden:ALDL_(8192_Baud) in the page for LINKTYPE_ALDL, to describe at least some of the ALDL payload.

And if it's different in the 160 baud link and the 8192 baud link, should this be LINKTYPE_ALDL_8192_BAUD?

And, as [the Wikipedia page for ALDL indicates](https://en.wikipedia.org/wiki/ALDL), how model-dependent is the format?

> Documentation is scarce, but the majority of ALDL devices that operate at 8192 baud has a consistent frame format of ` `. ...but is `` model-dependent (so that dissecting...