Guy Harris

So you're building the experimental daemon for a protocol, but not the client code for that protocol? :-)

1. This should be supported both by CMake *and* autotools. 1. There should be a *single* flag that enables both client and server, with a flag that enables just the...

> Yes. A use-case for this is to run `rpcapd` on a Linux machine and Wireshark on Windows which has support for the rpcap protocol (https://qnaplus.com/capture-protocol-packets-from-remote-windows-or-linux-computer-using-wireshark/). That's also a use...

The bulk of this should probably be done in libpcap, to 1) hide the platform dependency of the "wait for an interface to become available" mechanism and 2) allow other...

That still doesn't address the > Note that the underlying capture mechanism might not support a "start capturing as soon as an interface with a given name appears" feature, which...

> So it might be worth to consider if the new code could have just the declarations it needs, then it would be simpler to make these portable and have...

Here's a tarball containing a patch, pcap/batadv_legacy_packet.h, and pcap/batadv_packet.h. The patch is a variant of your change that compiles on macOS Catalina and Xcode 11.7, so it rips out enough...

Submitted by amotin Logged In: YES user_id=892211 Originator: YES It looks like I have found the reason. In first example X register is not ever used. So expression xval !=...

The user buffer should definitely be at least that big. Is there any reason to have it *bigger* than that, e.g. a multiple of that, to hold multiple maximum-sized buffers?

> Thank you for proposing these changes. Regardless of the more substantial aspects, which also need to be reviwed, it would be difficult to remember the difference between `pcap_dump1()` and...