learn
learn copied to clipboard
guyellis
Update dependency material-ui
material-ui is not showing up on outdated dependencies because it has moved to a scoped module under @material-ui - we are on 0.x and the latest at the time of writing this is 4.x
There are some upgrade guides:
https://material-ui.com/guides/migration-v0x/
https://material-ui.com/guides/migration-v3/
@guyellis About design, I was thinking about make something new with own components and css, no third party css libraries.
This should be a long and complex issue, maybe an epic issue, I know, but this is a stuff that I really like it!
Let me know what you think.
@mateusmarquezini - what are the pros and cons of doing each?
I see material-ui as an easy way to get a bunch of standardized controls that perform basic functionality at low cost. The maintenance of it is relatively low because that happens in their library and we are consumers.
If we were to do our own would that increase the maintenance needed in this repo?
I'm certainly open to change and I'd like to see more details around what you're proposing.
Here's an idea: Why don't we upgrade Material-UI so that we're on the latest version. Then you take one of the components and restyle it as you suggested and we look at that and compare the pros and cons of the against the Material-UI version. What do you think?
Hi @guyellis , sorry for the delay. Well, I think it's not about pros or cons, but the possibility to get the own design or style in the application, and you're right about material-ui. But it would take much time and a good study of this. But for now, let's upgrade it, I think actually it's the best way.
Hey @mateusmarquezini - I just came across this article: https://levelup.gitconnected.com/material-ui-styled-components-fff4d345fb07
I think that might solve your concern. Style Components or custom CSS could be used like that.
Hey, thanks @guyellis ! Yeah, it's something like that I was thinking about!
Hi @guyellis ! Sorry for the delay but I'm working very hard on this issue! :smiley: First of all, I've updated the React and Material UI version, after that, I was working on a bunch of improvements on the interface (menu, buttons, colors, etc...).
All these using Material UI components. As soon as possible, I'll post some stuff here for you check the changes, or if you want, you can run the application on branch issue_803_layout_improvements and give me some feedback .
No problem @mateusmarquezini - thanks for the update.
If you want to do a PR for just the React and MaterialUI upgrade first and then the others that might make the PRs smaller and easier to reason about.
If it's not possible to untangle that and the layout changes then don't worry about it and I'll wait for your PR.
hi @guyellis , as you told me, I just opened a new PR only with Material UI and React dependencies updated. A lot of files was changed as you can see there.