jmongo icon indicating copy to clipboard operation
jmongo copied to clipboard

Updated to use new MongoClient

Open jacaetevha opened this issue 12 years ago • 11 comments

Please take a look. I didn't spend a lot of time on this. And I only tested it against the specs you already had (which isn't very extensive). Seems to work fine.

jacaetevha avatar Nov 29 '12 21:11 jacaetevha

Thanks for taking time to do that. My only concern is that my patched version of the jar included support for Ruby Symbols. Over a year ago I created a JIRA JAVA-441 ticket to add it to the java driver but nothing was done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you interested in taking over this project?

guyboertje avatar Nov 30 '12 18:11 guyboertje

sure... I'll take it over

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje [email protected]:

Thanks for taking time to do that. My only concern is that my patched version of the jar included support for Ruby Symbols. Over a year ago I created a JIRA JAVA-441 ticket to add it to the java driver but nothing was done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you interested in taking over this project?

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10899256.

jacaetevha avatar Nov 30 '12 20:11 jacaetevha

How important is JAVA-441? Certainly we can get along with just strings. Right?

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje [email protected]:

Thanks for taking time to do that. My only concern is that my patched version of the jar included support for Ruby Symbols. Over a year ago I created a JIRA JAVA-441 ticket to add it to the java driver but nothing was done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you interested in taking over this project?

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10899256.

jacaetevha avatar Dec 03 '12 16:12 jacaetevha

The ruby driver supports deserializing symbols and so I wanted to try to maintain as much compatibility with the ruby driver as possible. I have sent a Pull Request to the java driver repo - but I suspect that they have no real way of field testing the change so they might not pull it. Is it important - I dunno, but the 1.1.5 gem that some people may be using does support symbols. How is your java fu? If you have a working up to date java tool chain in place, (I remeber it was a bit of a hassle to get the jar compiled) you could just keep changing the BasicBSONCallback.java file, compiling it and pushing it into the jar.

Have you looked at the Moped driver?

Guy

On Mon, Dec 3, 2012 at 4:54 PM, Jason Rogers [email protected]:

How important is JAVA-441? Certainly we can get along with just strings. Right?

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje [email protected]:

Thanks for taking time to do that. My only concern is that my patched version of the jar included support for Ruby Symbols. Over a year ago I created a JIRA JAVA-441 ticket to add it to the java driver but nothing was done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you interested in taking over this project?

— Reply to this email directly or view it on GitHub< https://github.com/guyboertje/jmongo/pull/4#issuecomment-10899256>.

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10961155.

guyboertje avatar Dec 03 '12 20:12 guyboertje

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

On Mon, Dec 3, 2012 at 3:22 PM, Guy Boertje [email protected]:

The ruby driver supports deserializing symbols and so I wanted to try to maintain as much compatibility with the ruby driver as possible. I have sent a Pull Request to the java driver repo - but I suspect that they have no real way of field testing the change so they might not pull it. Is it important - I dunno, but the 1.1.5 gem that some people may be using does support symbols. How is your java fu? If you have a working up to date java tool chain in place, (I remeber it was a bit of a hassle to get the jar compiled) you could just keep changing the BasicBSONCallback.java file, compiling it and pushing it into the jar.

Have you looked at the Moped driver?

Guy

On Mon, Dec 3, 2012 at 4:54 PM, Jason Rogers [email protected]:

How important is JAVA-441? Certainly we can get along with just strings. Right?

Jason Rogers

On Fri, Nov 30, 2012 at 1:45 PM, Guy Boertje [email protected]:

Thanks for taking time to do that. My only concern is that my patched version of the jar included support for Ruby Symbols. Over a year ago I created a JIRA JAVA-441 ticket to add it to the java driver but nothing was done about it. I will send them a pull request.

Unfortunately I am not using jmongo or jruby at the moment. Are you interested in taking over this project?

— Reply to this email directly or view it on GitHub< https://github.com/guyboertje/jmongo/pull/4#issuecomment-10899256>.

— Reply to this email directly or view it on GitHub< https://github.com/guyboertje/jmongo/pull/4#issuecomment-10961155>.

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10969875.

jacaetevha avatar Dec 03 '12 20:12 jacaetevha

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers [email protected]:

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

guyboertje avatar Dec 03 '12 22:12 guyboertje

Do you know of any benchmark suites for it?

Jason Rogers

On Mon, Dec 3, 2012 at 5:37 PM, Guy Boertje [email protected]:

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers <[email protected]

wrote:

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10975597.

jacaetevha avatar Dec 03 '12 22:12 jacaetevha

no - but I suspect the one that Chuck Remes built to benchmark his first version of jmongo would work. I think he deleted ithe github repo though. I might have a copy locally. I will look tonight.

On Mon, Dec 3, 2012 at 10:46 PM, Jason Rogers [email protected]:

Do you know of any benchmark suites for it?

Jason Rogers

On Mon, Dec 3, 2012 at 5:37 PM, Guy Boertje [email protected]:

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers <[email protected]

wrote:

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

Reply to this email directly or view it on GitHub< https://github.com/guyboertje/jmongo/pull/4#issuecomment-10975597>.

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10975909.

guyboertje avatar Dec 04 '12 09:12 guyboertje

Thanks. I'll work up a script as well.

Jason Rogers

On Tue, Dec 4, 2012 at 4:53 AM, Guy Boertje [email protected]:

no - but I suspect the one that Chuck Remes built to benchmark his first version of jmongo would work. I think he deleted ithe github repo though. I might have a copy locally. I will look tonight.

On Mon, Dec 3, 2012 at 10:46 PM, Jason Rogers [email protected]:

Do you know of any benchmark suites for it?

Jason Rogers

On Mon, Dec 3, 2012 at 5:37 PM, Guy Boertje [email protected]:

Have a look at the pull request - its a single line change.

Moped is v good. It was not available when jmongo started.

On Mon, Dec 3, 2012 at 8:52 PM, Jason Rogers <[email protected]

wrote:

My Java fu is fine, though I don't want to have to support a modified JAR.

Hadn't heard of moped. Will look into it.

Thanks.

Jason Rogers

Reply to this email directly or view it on GitHub< https://github.com/guyboertje/jmongo/pull/4#issuecomment-10975597>.

— Reply to this email directly or view it on GitHub< https://github.com/guyboertje/jmongo/pull/4#issuecomment-10975909>.

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-10990404.

jacaetevha avatar Dec 04 '12 14:12 jacaetevha

read this if you haven't already, about jmongo benchmarking ...

http://www.ruby-forum.com/topic/3841457

Chuck and I replied.

guyboertje avatar Dec 04 '12 15:12 guyboertje

Thanks.

Jason Rogers

On Tue, Dec 4, 2012 at 10:54 AM, Guy Boertje [email protected]:

read this if you haven't already, about jmongo benchmarking ...

http://www.ruby-forum.com/topic/3841457

Chuck and I replied.

— Reply to this email directly or view it on GitHubhttps://github.com/guyboertje/jmongo/pull/4#issuecomment-11002335.

jacaetevha avatar Dec 04 '12 17:12 jacaetevha