es-module-shims icon indicating copy to clipboard operation
es-module-shims copied to clipboard

Run tests in Firefox 115 because there's probably integrity check problem

Open kukulich opened this issue 11 months ago • 4 comments

We have strange errors in Firefox 115. Even when I run your tests in Firefox 115 I see error:

Should import a module via a relative path re-mapped with importmap's scopes
[‣](http://localhost:8080/test/test-shim.html?grep=Basic%20loading%20tests%20Should%20import%20a%20module%20via%20a%20relative%20path%20re%5Cx2dmapped%20with%20importmap%27s%20scopes)

TypeError: Unable to fetch http://localhost:8080/test/fixtures/es-modules/es6-dep.js imported from http://localhost:8080/test/fixtures/es-modules/es6-withdep.js - see network log for details.
NetworkError when attempting to fetch resource.

There's also error in console:

None of the “sha384” hashes in the integrity attribute match the content of the subresource. The computed hash is “St7RQt/YC0ARekmGQTSeF0WZ5RVtZ8rNAKHXNS7dwROC5uQAYq+k8e9Tsw6DFJsQ”.

The error is gone when I remove the integrity key from fetchOpts

kukulich avatar Jan 26 '25 09:01 kukulich

@kukulich this is because I run all the tests on Windows with carriage return line endings factored into the integrity, and CI runs on Windows as well.

If we want the test suite to pass on Mac / Linux then we would need to update the test suite to switch out the integrity on these systems with the integrity for the sources without the carriage return added by git.

guybedford avatar Jan 26 '25 20:01 guybedford

I use Windows as well.

kukulich avatar Jan 26 '25 20:01 kukulich

However it’s possible that my Git has different default settings

kukulich avatar Jan 26 '25 20:01 kukulich

Yes, you need to be running with git config --global core.autocrlf true on Windows.

guybedford avatar Jan 26 '25 20:01 guybedford