Guy Bedford

Results 1051 comments of Guy Bedford

Improving the lexing ambiguity cases is always a goal so thanks for posting, but yes there isn't a rush to fix this :) I wasn't aware the this would be...

I've posted a potential fix in https://github.com/guybedford/cjs-module-lexer/pull/21, interestingly it's a negative diff and thankfully doesn't require any extra work :) Would be grateful if you could review when you can.

@kriskowal nice to hear. es-module-lexer is a fork to also keep in sync and so far it hasn't been too bad at all to maintain that. If you hit any...

Thanks for finding this one! Fix added in https://github.com/guybedford/cjs-module-lexer/pull/23.

Looking at this more closely, it is effectively a class of ASI cases where we aren't detecting the `}` as a block when it should be. Some other variations: ```js...

Hi @FredKSchott, thanks for the feedback here. Do you have an exact example of the sort of code pattern you'd like to see supported? Arbitrary expressions can't be supported as...

Thanks, that was actually a readme typo - fixed in https://github.com/guybedford/cjs-module-lexer/commit/4d56d33f2de790a47450d8c5892509d94b338673. Would exactly supporting strings on the RHS specifically help in your use case? I didn't think this was such...

Thanks @fks, the faster you can run a feedback cycle here the better as we only have a short window before it locks down on Nodejs 12. If there’s something...

Yeah that’s the sort of case we have to draw a line on in not supporting unfortunately. Maybe if it were an explicit iteration and copy it could be considered,...

It is an unfortunate problem to work around. A couple of naive questions: 1. Would it be possible for JS to listen to the memory "change" event, and update any...